Ensure ChannelMonitorUpdates are ordered with full monitor writes
#3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update a channel, then while connecting a block persist a full `ChannelMonitor` prior to persisting the `ChannelMonitorUpdate`, users can end up seeing a full `ChannelMonitor` with a given `latest_update_id` prior to seeing the `ChannelMonitorUpdate` with the same `update_id`. This could cause users to have a full `ChannelMonitor` on disk as well as a `ChannelMonitorUpdate` which was already applied. While this isn't an issue for the LDK-provided update-based `Persist`, its somewhat surprising for users so we avoid it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
==========================================
- Coverage 89.78% 89.74% -0.04%
==========================================
Files 121 121
Lines 100932 100933 +1
Branches 100932 100933 +1
==========================================
- Hits 90619 90582 -37
- Misses 7635 7663 +28
- Partials 2678 2688 +10 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Jul 22, 2024
| /// Note that this lock must be held from [`ChannelMonitor::update_monitor`] through to | ||
| /// [`Persist::update_persisted_channel`] to prevent a race where we call | ||
| /// [`Persist::update_persisted_channel`], the user returns a | ||
| /// [`ChannelMonitorUpdateStatus::InProgress`], and then calls channel_monitor_updated |
Contributor
There was a problem hiding this comment.
nit: Since you're already here, mind ticking/linkng channel_monitor_updated / Vec as well?
| /// persist a full [`ChannelMonitor`] prior to persisting the [`ChannelMonitorUpdate`]. This | ||
| /// could cause users to have a full [`ChannelMonitor`] on disk as well as a | ||
| /// [`ChannelMonitorUpdate`] which was already applied. While this isn't an issue for the | ||
| /// LDK-provided update-based [`Persist`], its somewhat surprising for users so we avoid it. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// LDK-provided update-based [`Persist`], its somewhat surprising for users so we avoid it. | |
| /// LDK-provided update-based [`Persist`], it is somewhat surprising for users so we avoid it. |
Contributor
|
Going ahead and land this, nits could still be addressed in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update a channel, then while connecting a block persist a full
ChannelMonitorprior to persisting theChannelMonitorUpdate, users can end up seeing a fullChannelMonitorwith a givenlatest_update_idprior to seeing theChannelMonitorUpdatewith the sameupdate_id. This could cause users to have a fullChannelMonitoron disk as well as aChannelMonitorUpdatewhich was already applied. While this isn't an issue for the LDK-provided update-basedPersist, its somewhat surprising for users so we avoid it.I fought for a while with actually changing the locking structure to enforce this, but it ended up breaking the
LockedChannelMonitorstuff so I gave up.